Forum Replies Created
-
Posts
-
Great find. Just updated master_2019.2 version (v2019.2.28) on github to use the
SiLocal::dbStd(...)fix on both Itemized and Total style invoice unit prices. Also found and fixed an issue of Total style invoice handling of more than one tax item per line item used. The 2nd and on tax items we being ignored.Change any occurrence of
<td colspan="6"><br/></td>
to
<td colspan="6"> </td>In the case of
<td colspan="6"> <br/> <br/> </td>to
<td colspan="6"> </td> <td colspan="6"> </td>My test shows both the printer render and the PDF render honor this change whereas the PDF render ignores the
<br/>value in a table item definition.Is there an error in your tmp/log/php.log file? Also, check your database for the invoice_items with the greatest value (click on “id” sort once for low to high and then again for high to low). What does this show in the “invoice_id” field? The value in the “id” field contains the invoices table. There has been an issue in the past, where the “invoice_id” gets set to a zero value and so doesn’t show with the invoice., If this is the case, you can manually change the value in the database to fist the unattached invoice item. I would then suggest you perform a clean install of the current version of SI. By clean install, I mean the following:
1) Rename your current SI directory.
2) Download the master_2019.2 SI zip file from github.
3) Unzip the content of the downloaded zip file. Make sure you brows to the root directory for your web applications and then name the folder that will be unzipped to, to the name of your original SI directory renamed in step 1.
4) Copy the config/custom.config.php file from your renamed SI directory (step 1) to the config directory of the newly restored file path.At this point, you should be able to access your SI app. See if the problem you experienced has been fixed. Note that I assume that you reattached (so to speak) the invoice_items record(s) orphaned in the database to their associated invoices record(s). The verification that this issue has been resolved is that you will see invoice items defined for new and existing invoices properly associated with the invoice.
Let me know how this turns out.
Have you looked at the tmp/log/php.log file for an error? I assume the list of invoices on the primary screen shows correctly. If not, make sure that a public directory exists in the SI directory structure.
Select download on Github Fearless329 Simpleinvoices Master 2019.2 as shown in attach picture.
Attachments:
I’m unable to replicate this error. The lowest PHP level I can test at is 7.2x. If you can upgrade to 7.2x and use the master_2019.2 version, hopefully the error will go away. If not, I might be able to better test for your issue.
I took another look at this and believe that a solution was found. The update has been pushed to github for fearless359/master_2019 version 2019.1.2. If you try this, let me know how it works.
FYI, there is a new local.currency_code field in the custom.config.php file. It is added automatically but is likely not set right for you. Check for it under the [production] header and for clarity, move it to the other local settings for locale and precision.
Once this is set up, let me know the following:
1) local value settings in the custom.config.php file.
2) What are the settings for currency sign, currency code and locale fields in the INV PREFS (SETTINGS) for Invoice type records.I changed my settings to en_GB in custom.config.php and in the INV PREF (SETTINGS) for the Invoice to en_GB also. This still works find. When I look at the php error log you sent in a zip file earlier, I see that the comma is being carried through to the database insert. When I look at this same command on my system (it is my production linux based system but running php 7.3) the comma that is displayed on my screen disappears from the $_POST array value for this field. So I thought maybe something in your PHP settings. However the PHPINFO information you provided, I couldn’t see any setting that would do this. Note that my development system is windows running xampp currently PHP 7.4 and it works fine there also.
Bottom line is I don’t know what is going on. My best suggestion at this point is to install the latest master_2019.2 version (updated on June 3) as a fresh install. That is, don’t load it over anything existing install. You should be able to rename your current directory, create a new directory named what your old one was and then unzip the downloaded version of master_2019.2 content into it. Then copy your config/custom.config.php file from the old install to the new install. If you have any special files such as extensions or in the custom directory then copy those over. Also, if you have your own invoice template, you need to copy that directory to the templates/invoices directory, and copy any special logo images in the templates/invoices/logos directory to the new directory.
Sorry I don’t have a more definitive answer. The removal of the comma is being handled behind the scenes so just recommending a scatter-gun approach to see if it changes thing.
I think you addressed a symptom, not the problem. The existing code handles these values fine on my system. What server are you using (XAMPP, WAMP, Linux, etc.)? What version of PHP is running on that server?
Are you willing to share your phpinfo.php output? To do this, modify the phpinfo.php file that is in your primary directory and set the $secure variable to “true”. Then run it by entering your si URL with the file name. Ex: simepleinvoices/phpinfo.php if you use “simpleinvoices” to access your version of SI. Be sure to mask any personal info in this output before sharing it.
Note: Be sure to change the $secure variable back to “false” after getting this information.
If you want to point out what hard coded language you encounter, I endeavour to put the info in the LANG file so you can then add it to the Dutch file. In the meantime, I am making your work part of the standard package. Thanks for doing this…
The lang/get-new-strings.sh script lists differences. Here is an example of the script run against the da_DK file. The thing to look for are lines the are preceded by a dash. for example:
*** 11,14 ****
$LANG[‘add_new_biller’]
– $LANG[‘add_new_expense’]
– $LANG[‘add_new_expense_account’]
$LANG[‘add_new_invoice’]
— 12,13 —-This shows that the lines for add_new_expense and add_new_expense_account exist in the en_US lang file but not in the da_DK file.
To use the script, in a bash shell position yourself in the lang directory. Then execute the script as shown below:
$ ./get-new-strings.sh da_DK
*** /tmp/lang.en.tmp 2020-05-09 07:44:21.925277400 -0700
— /tmp/lang.da_DK.tmp 2020-05-09 07:44:21.996921600 -0700
***************
*** 1,2 ****
! global $databaseBuilt, $LANG;
$LANG[‘about’]
— 1,3 —-
! global $LANG;
! if ($LANG) {} // eliminates unused warning
$LANG[‘about’]
***************
*** 11,14 ****
$LANG[‘add_new_biller’]
– $LANG[‘add_new_expense’]
– $LANG[‘add_new_expense_account’]
$LANG[‘add_new_invoice’]
— 12,13 —-
***************
*** 19,21 ****
$LANG[‘add_new_tax_rate’]
– $LANG[‘add_new_user’]
$LANG[‘add_payment_type’]
— 18,19 —-
***************
*** 35,41 ****
$LANG[‘all_reports’]
– $LANG[‘always_enabled’]
$LANG[‘amount’]
$LANG[‘as_template’]
– $LANG[‘associated_table’]
– $LANG[‘attachments’]
$LANG[‘attention_short’]
— 33,36 —-
***************
*** 51,53 ****
$LANG[‘before_starting’]
– $LANG[‘billed’]
$LANG[‘biller’]
— 46,47 —-
***************
*** 62,79 ****
$LANG[‘billers’]
– $LANG[‘billing’]
$LANG[‘blog’]
$LANG[‘cancel’]
– $LANG[‘cancelled’]
$LANG[‘cannot_delete_first_row’]
$LANG[‘change_log’]
– $LANG[‘check_number’]
$LANG[‘city’]
– $LANG[‘clear_data’]
– $LANG[‘copied_from’]
– $LANG[‘company_logo’]
$LANG[‘company_name’]
– $LANG[‘company_name_item’]
– $LANG[‘company_name_item_label’]
$LANG[‘confirm_delete’]
– $LANG[‘confirm_password’]
$LANG[‘consulting’]
— 56,64 —-
***************
*** 91,94 ****
$LANG[‘credits’]
– $LANG[‘cron_delete_failure’]
– $LANG[‘cron_delete_success’]
$LANG[‘currency_code’]
— 76,77 —-
***************
*** 104,108 ****
$LANG[‘custom_fields_upper’]
– $LANG[‘custom_flags_upper’]
$LANG[‘custom_label’]
– $LANG[‘custom_upper’]
$LANG[‘customer’]
— 87,89 —-
***************
*** 128,130 ****
$LANG[‘days’]
– $LANG[‘db_backup’]
$LANG[‘debtors’]
— 109,110 —-
***************
*** 137,139 ****
$LANG[‘default_inv_template’]
– $LANG[‘default_invoice’]
$LANG[‘default_invoice_preference’]
— 117,118 —-
***************
*** 147,152 ****
$LANG[‘delete_row’]
– $LANG[‘delete_failed’]
– $LANG[‘delete_success’]
– $LANG[‘denied_page’]
$LANG[‘deleted’]
$LANG[‘description’]
— 126,129 —-
$LANG[‘delete_row’]
$LANG[‘deleted’]
+ $LANG[‘denied_page’]
$LANG[‘description’]
***************
*** 162,165 ****
$LANG[‘due’]
– $LANG[‘duplicate_product_value’]
– $LANG[‘duplicate_tax_description’]
$LANG[‘edit’]
— 139,140 —-
***************
*** 183,185 ****
$LANG[‘eway_merchant_xml’]
– $LANG[‘expense’]
$LANG[‘export_as’]
— 158,159 —-
***************
*** 192,197 ****
$LANG[‘export_xls_tooltip’]
– $LANG[‘expenses’]
– $LANG[‘expense_accounts’]
$LANG[‘extensions’]
– $LANG[‘failure’]
$LANG[‘faqs’]
— 166,168 —-
***************
*** 202,206 ****
$LANG[‘fax’]
– $LANG[‘field_label_upper’]
– $LANG[‘field_help_upper’]
– $LANG[‘fields_upper’]
$LANG[‘filter_by_dates’]
— 173,174 —-
***************
*** 208,213 ****
$LANG[‘financial_status’]
– $LANG[‘flag_number’]
– $LANG[‘flags_upper’]
$LANG[‘for’]
– $LANG[‘for_the_period_upper’]
$LANG[‘format_tooltip’]
— 176,178 —-
***************
*** 227,232 ****
$LANG[‘help_community_forums’]
– $LANG[‘help_company_logo’]
– $LANG[‘help_company_name’]
– $LANG[‘help_company_name_item’]
– $LANG[‘help_confirm_password’]
$LANG[‘help_cost’]
— 192,193 —-
***************
*** 234,254 ****
$LANG[‘help_custom_fields’]
– $LANG[‘help_custom_flags_associated_table’]
– $LANG[‘help_custom_flags_enable’]
– $LANG[‘help_custom_flags_field_help’]
– $LANG[‘help_custom_flags_field_label’]
– $LANG[‘help_custom_flags_flag_number’]
– $LANG[‘help_custom_field_cleanup’]
$LANG[‘help_customer_contact’]
– $LANG[‘help_customer_email’]
$LANG[‘help_database_patches’]
– $LANG[‘help_default_biller’]
– $LANG[‘help_default_customer’]
– $LANG[‘help_default_invoice’]
– $LANG[‘help_default_invoice_preference’]
$LANG[‘help_default_invoice_template_text’]
– $LANG[‘help_default_number_items’]
– $LANG[‘help_default_payment_type’]
– $LANG[‘help_default_tax’]
$LANG[‘help_delete’]
– $LANG[‘help_email_address’]
$LANG[‘help_email_bcc’]
— 195,200 —-
***************
*** 257,260 ****
$LANG[‘help_email_to’]
– $LANG[‘help_expense’]
– $LANG[‘help_expense_accounts’]
$LANG[‘help_insert_biller_text’]
— 203,204 —-
***************
*** 276,278 ****
$LANG[‘help_inv_pref_what_the’]
– $LANG[‘help_inventory’]
$LANG[‘help_invoice_create’]
— 220,221 —-
***************
*** 280,282 ****
$LANG[‘help_invoice_types’]
– $LANG[“help_language”]
$LANG[‘help_logging’]
— 223,224 —-
***************
*** 284,292 ****
$LANG[‘help_manage_custom_fields’]
– $LANG[‘help_manage_custom_flags’]
$LANG[‘help_mysql4’]
– $LANG[‘help_password_lower’]
– $LANG[‘help_password_min_length’]
– $LANG[‘help_password_number’]
– $LANG[‘help_password_special’]
– $LANG[‘help_password_upper’]
$LANG[‘help_process_payment_auto_amount’]
— 226,228 —-
***************
*** 294,303 ****
$LANG[‘help_process_payment_inv_id’]
– $LANG[‘help_product_attributes’]
$LANG[‘help_reports_xsl’]
$LANG[‘help_required_field’]
– $LANG[‘help_reset_custom_flags_products’]
– $LANG[‘help_set_aging’]
– $LANG[‘help_session_timeout’]
$LANG[‘help_si_help’]
– $LANG[‘help_signature’]
$LANG[‘help_simple_invoices’]
— 230,234 —-
***************
*** 305,314 ****
$LANG[‘help_tax_rate_sign’]
– $LANG[‘help_taxes_per_line_item’]
$LANG[‘help_text’]
– $LANG[‘help_user_enabled’]
– $LANG[‘help_user_id’]
$LANG[‘help_user_role’]
– $LANG[‘help_username’]
$LANG[‘help_what_are_custom_fields’]
– $LANG[‘help_what_are_custom_flags’]
$LANG[‘help_wheres_the_edit_button’]
— 236,240 —-
***************
*** 320,322 ****
$LANG[‘included’]
– $LANG[‘information’]
$LANG[‘insert_biller’]
— 246,247 —-
***************
*** 335,337 ****
$LANG[‘inv_pref_short’]
– $LANG[‘inv_prefs’]
$LANG[‘inv_total’]
— 260,261 —-
***************
*** 357,359 ****
$LANG[‘invoice_summary’]
– $LANG[‘invoice_total’]
$LANG[‘invoice_type’]
— 281,282 —-
***************
*** 364,366 ****
$LANG[‘itemised_style’]
– $LANG[‘last_invoice’]
$LANG[‘language’]
— 287,288 —-
***************
*** 397,399 ****
$LANG[‘more_info’]
– $LANG[‘more_than_one_pymt_rec’]
$LANG[‘mysql4_features_disabled’]
— 319,320 —-
***************
*** 401,404 ****
$LANG[‘need_help’]
– $LANG[‘net_income_report’]
– $LANG[‘new_uppercase’]
$LANG[‘new_inventory_movement’]
— 322,323 —-
***************
*** 413,419 ****
$LANG[‘no_crons’]
– $LANG[‘no_custom_flags’]
$LANG[‘no_customers’]
$LANG[‘no_defaults’]
– $LANG[‘no_expenses’]
– $LANG[‘no_expense_accounts’]
$LANG[‘no_help_page’]
— 332,335 —-
***************
*** 427,430 ****
$LANG[‘no_preferences’]
– $LANG[‘no_product_attributes’]
– $LANG[‘no_product_values’]
$LANG[‘no_products’]
— 343,344 —-
***************
*** 433,435 ****
$LANG[‘none’]
– $LANG[‘not_paid’]
$LANG[‘note’]
— 347,348 —-
***************
*** 443,445 ****
$LANG[‘of’]
– $LANG[‘on_cap’]
$LANG[‘online_payment_id’]
— 356,357 —-
***************
*** 449,451 ****
$LANG[‘other’]
– $LANG[‘outstanding’]
$LANG[‘owing’]
— 361,362 —-
***************
*** 453,462 ****
$LANG[‘paid’]
– $LANG[‘past_due_report’]
– $LANG[‘past_due_upper’]
$LANG[‘password’]
– $LANG[‘password_lower’]
– $LANG[‘password_min_length’]
– $LANG[‘password_number’]
– $LANG[‘password_special’]
– $LANG[‘password_upper’]
$LANG[‘payment’]
— 364,366 —-
***************
*** 494,496 ****
$LANG[‘prepare_simple_invoices’]
– $LANG[‘previously’]
$LANG[‘price’]
— 398,399 —-
***************
*** 526,528 ****
$LANG[‘provision_of’]
– $LANG[‘pymt_types’]
$LANG[‘quantity’]
— 429,430 —-
***************
*** 539,544 ****
$LANG[‘reorder_level’]
– $LANG[‘report’]
$LANG[‘reports’]
$LANG[‘required_field’]
– $LANG[‘reset_custom_flags’]
$LANG[‘role’]
— 441,444 —-
***************
*** 547,552 ****
$LANG[‘sales_by_customers’]
– $LANG[‘sales_by_representative’]
$LANG[‘sales_report’]
– $LANG[‘sales_representative’]
– $LANG[‘sales_summary’]
$LANG[‘sanity_check’]
— 447,449 —-
***************
*** 561,564 ****
$LANG[‘save_custom_field_success’]
– $LANG[‘save_custom_flags_failure’]
– $LANG[‘save_custom_flags_success’]
$LANG[‘save_customer’]
— 458,459 —-
***************
*** 569,574 ****
$LANG[‘save_defaults_success’]
– $LANG[‘save_expense_account_failure’]
– $LANG[‘save_expense_account_success’]
– $LANG[‘save_expense_failure’]
– $LANG[‘save_expense_success’]
$LANG[‘save_eway_check_failed’]
— 464,465 —-
***************
*** 591,598 ****
$LANG[‘save_product’]
– $LANG[‘save_product_attributes_failure’]
– $LANG[‘save_product_attributes_success’]
$LANG[‘save_product_failure’]
$LANG[‘save_product_success’]
– $LANG[‘save_product_value_failure’]
– $LANG[‘save_product_value_success’]
$LANG[‘save_tax_rate’]
— 482,485 —-
***************
*** 603,608 ****
$LANG[‘select_invoice’]
– $LANG[‘selection_period’]
– $LANG[‘session_timeout’]
– $LANG[‘set_aging’]
– $LANG[‘setting’]
$LANG[‘settings’]
— 490,491 —-
***************
*** 619,621 ****
$LANG[‘simple_invoices’]
– $LANG[‘signature’]
$LANG[‘start_date’]
— 502,503 —-
***************
*** 635,637 ****
$LANG[‘street’]
– $LANG[‘street_address’]
$LANG[‘street2’]
— 517,518 —-
***************
*** 642,644 ****
$LANG[‘summary_of_accounts’]
– $LANG[‘success’]
$LANG[‘system_defaults’]
— 523,524 —-
***************
*** 683,686 ****
$LANG[‘total_by_aging_periods’]
– $LANG[‘total_cost’]
– $LANG[‘total_income’]
$LANG[‘total_invoices’]
— 563,564 —-
***************
*** 690,692 ****
$LANG[‘total_paid’]
– $LANG[‘total_paid_this_period’]
$LANG[‘total_sales’]
— 568,569 —-
***************
*** 702,707 ****
$LANG[‘upgrading_simple_invoices’]
– $LANG[‘use_this_pref’]
$LANG[‘user_add’]
– $LANG[‘user_id’]
– $LANG[‘username’]
$LANG[‘users’]
— 579,581 —-
***************
*** 716,718 ****
$LANG[‘what_are_custom_fields’]
– $LANG[‘what_are_custom_flags’]
$LANG[‘whats_all_this_inv_pref’]
— 590,591 —-
***************
*** 723,726 ****
$LANG[‘your_reports’]
– $LANG[‘zero_invoice_amt’]
$LANG[‘zip’]
– $LANG[‘help_new_password’]
— 596,597 —
Recent Comments