joncas

Forum Replies Created

Viewing 3 posts - 1 through 3 (of 3 total)
  • Author
    Posts
  • in reply to: three sql errors when upgrading from 2013.1.beta.8 #879
    joncas
    Participant

    One more patch that would be needed when upgrading older si databases is to add the password constraints to the si_system_defaults table:

    password_lower
    password_min_length
    password_number
    password_special
    password_upper

    Otherwise the validation pattern in the user edit form doesn’t accept any password changes.
    Enclosed is the patch update display that showed when first opening the old database with Master_2019.2
    After applying them all, the password constraints were still missing in the si_system_defaults table.

    joncas
    Participant

    Hello,

    It may depend on the localization settings? This site is set to British English, so numbers display with a comma as thousands separator (see enclosed screenshot), and apparently this is passed on in the POST arguments because the sql error was complaining that this was being used in the insert command.
    In your code the “edit” function already did use SiLocal::dbStd to filter that out, so it would seem logical that the insert should, too, no?

    Enclosed also the phpinfo: this is a dedicated Linux server running Ubuntu 18.04

    Attachments:
    You must be logged in to view attached files.
    joncas
    Participant

    p.s.: Searching the files listed in the error log, it looks like the patch would be on in /modules/invoices/save.php
    the “insert” case on line 71, one should use SiLocal::dbStd($_POST[“unit_price$i”]) instead of the unmodified $_POST[“unit_price$i”] (as the “edit” case does)

    • This reply was modified 2 weeks, 1 day ago by joncas.
Viewing 3 posts - 1 through 3 (of 3 total)