Forum Replies Created
-
Posts
-
I would be interested to see what you can do as well.
This is basically what is stopping me from upgrading to the latest version at the moment. I tried to rewrite my template but it is just not as good as it was!
Hi Richards,
Thanks for your help and patience.
I didn’t have the latest version from the github which contains the new code for the function. After I downloaded it I can report that theprint_if_not_emptyfunction is now working as intended.I now just have a few tweaks to do in my template and I will be able to switch to the master_2020 version on my production machine.
Good news!
It turns out I was not quite up to date with github. I couldn’t find the $class2 your were talking about.
So I downloaded the latest version and now it works. If I use print_if_not_empty then it now works.Hi,
Sorry for the delay been away.I cleared my plugins directory and deleted everything in tmp and the problem remains.
I can wait for your next update and hopefully something will change.It must be something with my setting or my database then because I have the same issue when I use the other templates provided by default.
Ok so may be I am missing something but it doesn’t seem to work for me. Here is an extract of an invoice. As you can see the field phone, fax, mobile and email are empty but the field is still displayed.
Here is the code I am using in my template:
{print_if_not_empty label=$LANG.phoneShort field=$customer.phone class1='' class2='' colspan="3"} {print_if_not_empty label=$LANG.fax field=$customer.fax class1='' class2='' colspan="3"} {print_if_not_empty label=$LANG.mobileShort field=$customer.mobile_phone class1='' class2='' colspan="3"} {print_if_not_empty label=$LANG.email field=$customer.email class1='' class2='' colspan="3"}I have tried with print_if_not_null as well and the result is the same.
Attachments:
Ok so
!emptydoes fix the problem I have withisset. ThanksHow about the
print_if_not_nullfunction? I found that there isprint_if_not_emptybut looking at the code it is actually the same as print_if_not_null.
I guess I will copy that function, put it in my theme plugins and replace isset by !emptyIs there any reason why the “empty” field are not set to NULL when not populated? The talbe definition seems to indicate that the defaul should be NULL
If you are using the latest master-2020 version then updating PHP to 7.4 is a requirement and might solve your issue
and some empty field from that table
select attention, phone, street_address from si_customers where name= “Andy”;
+———–+——-+—————-+
| attention | phone | street_address |
+———–+——-+—————-+
| | | |
+———–+——-+—————-+Here are some printout. I could not put them in the main post as it was telling me it looks like spam!
describe si_customers; +--------------------------+------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +--------------------------+------------------+------+-----+---------+----------------+ | id | int(11) unsigned | NO | PRI | NULL | auto_increment | | domain_id | int(11) unsigned | NO | PRI | NULL | | | attention | varchar(255) | YES | | NULL | | | name | varchar(255) | YES | | NULL | | | department | varchar(255) | YES | | NULL | | | street_address | varchar(255) | YES | | NULL | | | street_address2 | varchar(255) | YES | | NULL | | | city | varchar(255) | YES | | NULL | | | state | varchar(255) | YES | | NULL | | | zip_code | varchar(20) | YES | | NULL | | | country | varchar(255) | YES | | NULL | | | phone | varchar(255) | YES | | NULL | | | mobile_phone | varchar(255) | YES | | NULL | | | fax | varchar(255) | YES | | NULL | | | email | varchar(255) | YES | | NULL | | | credit_card_holder_name | varchar(255) | YES | | NULL | | | credit_card_number | varchar(20) | YES | | NULL | | | credit_card_expiry_month | varchar(2) | YES | | NULL | | | credit_card_expiry_year | varchar(4) | YES | | NULL | | | notes | text | YES | | NULL | | | parent_customer_id | int(11) | YES | | NULL | | | default_invoice | int(10) unsigned | NO | | 0 | | | custom_field1 | varchar(255) | YES | | NULL | | | custom_field2 | varchar(255) | YES | | NULL | | | custom_field3 | varchar(255) | YES | | NULL | | | custom_field4 | varchar(255) | YES | | NULL | | | enabled | tinyint(1) | NO | | 1 | | +--------------------------+------------------+------+-----+---------+----------------+ 27 rows in set (0.002 sec)I have updated the latest files and can confirm that it is fixed!
Thanks a lot.
I can now write another post for what I think is an issue with my database format…
ok the forum does quite a nice job at displaying the data. I replaced some bank data…
select * from si_preferences; +---------+-----------+------------------+--------------------+------------------+------------------+-------------------------+--------------------------------------------------------------------------------------------------------------+-------------------------+-----------------------------+------------------------------+-----------------------------+------------------------------+--------------+--------+--------+----------+-------------+-----------+---------------+------------------------+-------------------+ | pref_id | domain_id | pref_description | pref_currency_sign | pref_inv_heading | pref_inv_wording | pref_inv_detail_heading | pref_inv_detail_line | pref_inv_payment_method | pref_inv_payment_line1_name | pref_inv_payment_line1_value | pref_inv_payment_line2_name | pref_inv_payment_line2_value | pref_enabled | status | locale | language | index_group | set_aging | currency_code | include_online_payment | currency_position | +---------+-----------+------------------+--------------------+------------------+------------------+-------------------------+--------------------------------------------------------------------------------------------------------------+-------------------------+-----------------------------+------------------------------+-----------------------------+------------------------------+--------------+--------+--------+----------+-------------+-----------+---------------+------------------------+-------------------+ | 1 | 1 | Invoice Philippe | £ | Invoice | Invoice | Bank Details | bank | name | Sort Code: | code | Account number: | account | 1 | 1 | en_GB | en_GB | 1 | 1 | GPB | | left | | 2 | 1 | Receipt | £ | Receipt | Receipt | Details | <br />This transaction has been paid in full, please keep this receipt as proof of purchase.<br /> Thank you | | | | | | 1 | 1 | en_GB | en_GB | 1 | 0 | GPB | | left | | 3 | 1 | Estimate | £ | Estimate | Estimate | Details | <br />This is an estimate of the final value of services rendered.<br />Thank you | | | | | | 1 | 1 | en_GB | en_GB | 1 | 0 | GPB | | left | | 4 | 1 | Quote | £ | Quote | Quote | Details | <br />This is a quote of the final value of services rendered.<br />Thank you | | | | | | 1 | 1 | en_GB | en_GB | 1 | 0 | GPB | | left | | 5 | 1 | Invoice Penny | £ | invoice | | | | | | | | | 1 | 1 | en_GB | en_GB | 5 | 1 | UKP | | NULL | +---------+-----------+------------------+--------------------+------------------+------------------+-------------------------+--------------------------------------------------------------------------------------------------------------+-------------------------+-----------------------------+------------------------------+-----------------------------+------------------------------+--------------+--------+--------+----------+-------------+-----------+---------------+------------------------+-------------------+here is si_system_defaults
select * from si_system_defaults; +----+--------------------------+--------------------------+-----------+--------------+ | id | name | value | domain_id | extension_id | +----+--------------------------+--------------------------+-----------+--------------+ | 1 | biller | 4 | 1 | 1 | | 2 | customer | 1 | 1 | 1 | | 3 | tax | 4 | 1 | 1 | | 4 | preference | 5 | 1 | 1 | | 5 | line_items | 1 | 1 | 1 | | 6 | template | penny | 1 | 1 | | 7 | payment_type | 3 | 1 | 1 | | 8 | language | en_GB | 1 | 1 | | 9 | dateformate | Y-m-d | 1 | 1 | | 10 | spreadsheet | xls | 1 | 1 | | 11 | wordprocessor | doc | 1 | 1 | | 12 | pdfscreensize | 800 | 1 | 1 | | 13 | pdfpapersize | A4 | 1 | 1 | | 14 | pdfleftmargin | 15 | 1 | 1 | | 15 | pdfrightmargin | 15 | 1 | 1 | | 16 | pdftopmargin | 15 | 1 | 1 | | 17 | pdfbottommargin | 15 | 1 | 1 | | 18 | emailhost | localhost | 1 | 1 | | 19 | emailusername | | 1 | 1 | | 20 | emailpassword | | 1 | 1 | | 21 | logging | 1 | 1 | 1 | | 22 | delete | 1 | 1 | 1 | | 23 | tax_per_line_item | 1 | 1 | 1 | | 24 | inventory | 0 | 1 | 1 | | 25 | product_attributes | 1 | 1 | 1 | | 27 | company_logo | simple_invoices_logo.png | 1 | 1 | | 28 | company_name_item | SimpleInvoices | 1 | 1 | | 29 | password_min_length | 8 | 1 | 1 | | 30 | password_lower | 1 | 1 | 1 | | 31 | password_number | 1 | 1 | 1 | | 32 | password_special | 0 | 1 | 1 | | 33 | password_upper | 1 | 1 | 1 | | 34 | session_timeout | 60 | 1 | 1 | | 35 | default_invoice | 0 | 1 | 1 | | 36 | expense | 0 | 1 | 1 | | 37 | sub_customer | 0 | 1 | 1 | | 38 | product_groups | 0 | 1 | 1 | | 39 | invoice_description_open | 1 | 1 | 1 | +----+--------------------------+--------------------------+-----------+--------------+ 38 rows in set (0.010 sec)For si_preferences it is a bit more complicated. I don’t know how to display it in a nice way and it contains some sensitive information.
is there anything in particular you want to see?What I see is that when I click on setting then select the tab SI Default then “Default Invoice Preference: ” shows Quote but if I edit it will show the correct invoice that I want to use.
See the screenshots
So the system displays and use the correct value but the wrong one is displayed in the SI Default tab
Hi,
Just uploaded and got the following update:SQL patch 323, Add invoice description open option has not been applied to the databaseAfter I could enable the feature and it all works. The description is open by default.
That’s great! I will show it to my wife and see what she thinks. It would certainly makes my life simpler.
Thank you
PS: my second “feature” request would be good too 😉
Recent Comments